评分选 TR、阶段最小跨度、elements_only 门闩、Top-8 VP;无币种独立参数。 Co-authored-by: Cursor <cursoragent@cursor.com>
1.1 KiB
1.1 KiB
CODE_REVIEW — ECR-004
Role: REVIEWER
Date: 2026-08-06
Scope: 威科夫硬化(评分 TR / 阶段 / VP 减负 / API 门闩)
Decision: Approve
Evidence
chanlun/analysis/wyckoff/range.py、events.pyweb/api/analyze.py、chart_tv.jstests/test_wyckoff.py、web/tests/test_analyze_contract.py- IMPL / TEST / ENG SPEC
Acceptance ↔ Evidence
| Acceptance | Verdict | Evidence |
|---|---|---|
| 合成 TR 边界与起点 | PASS | abs_start≥12;low/high∈箱体带 |
| VP series 减负 | PASS | Top-8 + 填充 3 + levels;bins≤24 |
| 阶段最小跨度/不重合 | PASS | 链式切分;单测 unique keys |
| elements_only 门闩 | PASS | 契约测试 |
| golden 不变 | PASS | golden 套件 |
| 无币种参数 / 无策略改动 | PASS | diff 范围 |
复跑
→ 14 passed
Findings
Non-blocking
- 尾部短时可能只输出 A–C(无 D/E)——符合「空间不足截断」规则。
- 评分权重仍为启发式,实盘 BTC 以外未矩阵验证(本 ECR 明确不做币种表)。
No blockers
Decision
Approve