feat(ECR-010): Ops-E 系统运营;修复登出解绑;P2 Complete
落地管理员 RBAC/封禁/推送任务 stub,logout 解绑 device 并统一各页 ensureAccount,同时收口 P2 生日生成与状态文档。 Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -0,0 +1,32 @@
|
||||
# CODE_REVIEW — ECR-010 Ops-E
|
||||
|
||||
**Date:** 2026-08-11
|
||||
**Reviewer:** Agent (pre-landing)
|
||||
**Verdict:** Approve
|
||||
|
||||
## Checklist(.ai/review.md)
|
||||
|
||||
| Area | Result | Note |
|
||||
|------|--------|------|
|
||||
| Architecture | PASS | Handler→Service→Repo;DeviceAuth 闸门 |
|
||||
| Naming | PASS | ban/unban · role · push_jobs 与 Spec 一致 |
|
||||
| Performance | PASS | 列表有 limit |
|
||||
| Security | PASS | RBAC 服务端校验;末位 super 降级 → 40901 |
|
||||
| Readability | PASS* | 新文件合规;`admin_repo.go` 仍超 400(旧债) |
|
||||
| Error handling | PASS | `errors.Is` + sentinel;push title 长度 → 400 |
|
||||
| Logging | N/A | 审计表覆盖关键动作 |
|
||||
| Test | PASS | last-super · long title · ban · RBAC |
|
||||
| Deployment | PASS | migration 000016 |
|
||||
| Docs | PASS | Spec · OpenAPI 已补 409 |
|
||||
| Design | PASS | admin-h5 导航裁剪 |
|
||||
| Environment | PASS | |
|
||||
| Scope | PASS* | 落地时仍建议与 P2 文档拆 commit |
|
||||
|
||||
## Fixed since Conditional Approve
|
||||
|
||||
- P0:`CountAdminsByRole` + `ErrLastSuper`(40901) — integration 覆盖
|
||||
- P1:repo sentinel + `errors.Is`;push title ≤128 runes → 40055
|
||||
|
||||
## Residual(接受)
|
||||
|
||||
- 真推送未接;user 级封禁非 device 级;工作区可另拆 P2 commit
|
||||
Reference in New Issue
Block a user