refactor(ECR-001): Phase F types/sdk 对齐并拆分超标 H5 页
抽出 OpenAPI DTO;将 Ask/Report/Profile/Star 等 8 页拆到 ≤400 行,并修 ScaleSummary、fortuneKey、Scale 选答与单测。 Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -0,0 +1,53 @@
|
||||
# CODE_REVIEW — ECR-001 Phase F + H5 splits
|
||||
|
||||
**Reviewer:** Cursor Agent (REVIEWER)
|
||||
**Date:** 2026-08-05
|
||||
**Decision:** **PASS**(Should-fix 已修)
|
||||
|
||||
## Scope reviewed
|
||||
|
||||
- `packages/types` / `packages/sdk`:DTO 抽出,路径不变
|
||||
- H5 拆分:Ask / Report / Profile / StarProfile / Relation / Scale / ImageCard / LifeRhythm
|
||||
- 配套 composables×8 + components×~36
|
||||
- Spec 对齐:Ask / StarProfile / Membership
|
||||
- **Follow-up fix(同切片):** ScaleSummary 收敛 · fortuneKey lifetime · ScaleAnswering emit · StarProfile 单测补强
|
||||
|
||||
## Evidence
|
||||
|
||||
| Check | Result |
|
||||
|-------|--------|
|
||||
| API URL / 方法名未改 | PASS |
|
||||
| Page → composable → component 接线 | PASS |
|
||||
| 页面与子组件 ≤400 行 | PASS |
|
||||
| `ScaleSummary` = Go `ScaleListItem`(slug/title/description) | PASS |
|
||||
| `fortuneKey` 含 `lifetime` | PASS |
|
||||
| Scale 选答经 `@answer` emit,无 prop 深层 v-model | PASS |
|
||||
| StarProfile 星盘相位 + 运势今日/一生断言 | PASS |
|
||||
| `build:h5` + `test:h5` 35/35 | PASS |
|
||||
|
||||
## Findings
|
||||
|
||||
### Blockers
|
||||
无。
|
||||
|
||||
### Should-fix
|
||||
已全部修复(见 Follow-up)。
|
||||
|
||||
### Nits(不阻断)
|
||||
|
||||
1. Relation / ImageCard 单测 `router-link` 未 stub → Vue warn(既有)。
|
||||
2. Commit message 需带 `ECR-001`;勿提交 `config.local.yaml` / `test-results/`。
|
||||
|
||||
## Risk
|
||||
|
||||
**低。**
|
||||
|
||||
## Gate
|
||||
|
||||
- [x] Architecture / layering PASS
|
||||
- [x] No API URL change
|
||||
- [x] Tests green
|
||||
- [x] Should-fix closed
|
||||
- [ ] Human commit
|
||||
|
||||
**Decision: PASS**
|
||||
Reference in New Issue
Block a user