Files
digital-psychology/docs/CODE_REVIEW/ECR-008.md
T
jackyu66gitandCursor d33c8fdfe9 feat(ECR-012): 星座对齐收口,并 Closed ECR-007/008
对齐 outlook/分享 type=star/报告页运势面板与测试;流程上关闭 Ops-B/C 两张 ECR。真支付仍后置。

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-07 15:48:19 +08:00

1.5 KiB
Raw Blame History

CODE_REVIEW — ECR-008

Verdict: ApproveFeature Complete · Ops-C · P1 已修)

Date: 2026-08-07 · Reviewer pass → P1 fixed

Checklist

  • Handler → Service → Repositoryhome DeviceAuthadmin AdminAuth
  • Feature Spec Active + BD-2026-008 Approved
  • OpenAPI home/admin content paths
  • Migration 000014_ops_content · ERD
  • path/icon 白名单;审计与变更同事务ReplaceAllWithAudit / UpdateStatusWithAudit
  • C 端 Get/Submit 仅 published scales
  • H5 静态回退;integration 绿(含 audit 断言 + tools restore

P1 — resolved

ID Fix
P1-1 审计非原子 HomeToolsRepo.ReplaceAllWithAudit · ScaleRepo.UpdateStatusWithAudit
P1-2 ↑↓ 破坏 row_index ContentPage.move 仅交换位置并按行重算 sort_order
P1-3 Analytics nil requireAnalytics 统一守卫

P2(可跟进)

  • Scales 直连 ScaleRepoC 端多暴露字段;icon 白名单三处重复;OpenAPI schema 偏薄

Architecture Regression

  • 无 Handler 直连 DB
  • Admin / Device 鉴权隔离
  • 未引入非默认中间件
  • 审计与写操作同事务

Closed decision2026-08-07

Load Agent Profile: REVIEWER
Decision: Approve → Closed
Evidence: TEST_REPORT/ECR-008.md · P1 已修 · Acceptance 全勾 · ess-validate --phase review PASS
Residual: P2 可跟进项不阻断 Closed;部署属 RELEASE_MANAGER + Human