jackyu66gitandCursor
bd22d9dddd
落地 synastry/star/ask API 与 H5 页面，补齐 cece-frontend-re complete-design 证据文档，并加入 Android 模拟器截图抓取脚本。 Co-authored-by: Cursor <cursoragent@cursor.com>
45 lines
1.6 KiB
Markdown
45 lines
1.6 KiB
Markdown
# AI Self-Review — mandatory before claiming Done
|
|
|
|
After coding, check every item.
|
|
**Canonical gate:** `.ai/definition-of-done.md` — output **Review Report** (§7) when claiming Done.
|
|
Below checklist may be used as detail; labels: Demo | Feature Complete | P1 Complete.
|
|
|
|
## Checklist
|
|
|
|
| Area | Ask |
|
|
|---|---|
|
|
| Architecture | Layers respected? No Handler→DB? |
|
|
| Naming | Consistent domain terms? |
|
|
| Performance | Obvious N+1 / unbounded lists? |
|
|
| Security | AuthZ, validation, no secrets? |
|
|
| Readability | Files ≤400, funcs ≤50? |
|
|
| Error handling | Wrapped errors / user-safe messages? |
|
|
| Logging | Structured, no PII spam? |
|
|
| Test | Critical path covered or smoke listed? |
|
|
| Deployment | Migration / health / env noted if needed? |
|
|
| Docs | OpenAPI / PRD touch if public behavior changed? |
|
|
| Design | UI change? Tokens + catalog + platform contract followed? |
|
|
| Environment | Local workflow still host Go/Vite + deps-only compose? No Docker-only coding? |
|
|
| Scope | No unrelated files modified? |
|
|
|
|
## Output format (required)
|
|
|
|
```
|
|
## Review
|
|
- Architecture: PASS | FAIL — <note>
|
|
- Naming: PASS | FAIL — <note>
|
|
- Performance: PASS | FAIL — <note>
|
|
- Security: PASS | FAIL — <note>
|
|
- Readability: PASS | FAIL — <note>
|
|
- Error handling: PASS | FAIL — <note>
|
|
- Logging: PASS | FAIL — <note>
|
|
- Test: PASS | FAIL — <note>
|
|
- Deployment: PASS | FAIL — <note>
|
|
- Docs: PASS | FAIL — <note>
|
|
- Design: PASS | FAIL | N/A — <note>
|
|
- Environment: PASS | FAIL | N/A — <note>
|
|
- Scope: PASS | FAIL — <note>
|
|
```
|
|
|
|
Any FAIL → fix before finishing. Do not hide FAILs.
|